Skip to content

Fix point cloud bounds#1656

Open
rhaschke wants to merge 4 commits intoros-visualization:melodic-develfrom
rhaschke:fix-misc-point-cloud-bounds
Open

Fix point cloud bounds#1656
rhaschke wants to merge 4 commits intoros-visualization:melodic-develfrom
rhaschke:fix-misc-point-cloud-bounds

Conversation

@rhaschke
Copy link
Copy Markdown
Contributor

This is a rework of #1644, targeted at Melodic.

getSquaredViewDepth() was not applying scene node transforms to the
bounding box' center, resulting in incorrect squared distance to camera.
Compute *local* bounding radius from bounding box size.
Bounding sphere should be local to bounding box, not consider max length of point vectors.
If the cloud is shifted strongly into some direction, those lengths will be large,
although the bounding box (and sphere) can be small.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant